go-ethereum icon indicating copy to clipboard operation
go-ethereum copied to clipboard

Published 20 hours ago • verified publisher icon ethereum

Implement EIP-4844

Open roberto-bayardo opened this issue 2 years ago • 2 comments

This PR builds on top of the stake withdrawals work (https://github.com/ethereum/go-ethereum/pull/25838)

roberto-bayardo avatar Nov 30 '22 20:11 roberto-bayardo

QQ: I see that the ExcessDataGas is calculated during the finalization of the header, but I don't see where it is verified when receiving a block. Could you point me to where this is validated?

MariusVanDerWijden avatar Jan 24 '23 15:01 MariusVanDerWijden

QQ: I see that the ExcessDataGas is calculated during the finalization of the header, but I don't see where it is verified when receiving a block. Could you point me to where this is validated?

it's not, will add.

roberto-bayardo avatar Jan 26 '23 09:01 roberto-bayardo

This PR has been superseded by several other PRs, and will not be merged. I am closing this now, since it's no longer relevant for this repo.

holiman avatar Aug 26 '23 08:08 holiman

Thanks for your work @roberto-bayardo! It was a great help when I implemented our 4844 version. I think I even lifted some of your test cases

MariusVanDerWijden avatar Aug 29 '23 15:08 MariusVanDerWijden