go-ethereum icon indicating copy to clipboard operation
go-ethereum copied to clipboard

Published 20 hours ago • verified publisher icon ethereum

Clean up use of snapshot dangling storage check

Open aaronbuchwald opened this issue 3 years ago • 1 comments

This PR makes a few small cleanup changes in the snapshot code:

  • Remove unused checkDanglingStorage function in cmd/geth/snapshot.go
  • Removes an unused parameter from makeStorageTrie
  • Returns an error instead of just logging an error in a check for dangling storage to ensure tests will fail instead of just logging an error

aaronbuchwald avatar Jul 07 '22 15:07 aaronbuchwald

Removes an unused parameter from makeStorageTrie

These parameters will be used very soon. Since we are now switching to new trie scheme which is a huge change, a part of small changes have been merged into master right now, but somehow not used yet. Please remove these changes from your PR.

rjl493456442 avatar Jul 08 '22 03:07 rjl493456442