EIP-7702: Set EOA account code
Current status:
- Some EEST failures due to changed state test format (too wide values for
s,chain_id,noncein authorizations) - Need some optimizations, related to new StateDiff API, see TODOs in recent commits
Depends on https://github.com/ethereum/evmc/pull/720
Codecov Report
Attention: Patch coverage is 97.54098% with 9 lines in your changes missing coverage. Please review.
Project coverage is 94.37%. Comparing base (
14e62c4) to head (4358516). Report is 12 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #961 +/- ##
==========================================
+ Coverage 94.29% 94.37% +0.07%
==========================================
Files 159 162 +3
Lines 17344 17687 +343
==========================================
+ Hits 16355 16692 +337
- Misses 989 995 +6
| Flag | Coverage Δ | |
|---|---|---|
| eof_execution_spec_tests | 15.79% <11.20%> (-0.13%) |
:arrow_down: |
| ethereum_tests | 26.53% <9.83%> (-0.38%) |
:arrow_down: |
| ethereum_tests_silkpre | 18.72% <8.00%> (-0.25%) |
:arrow_down: |
| execution_spec_tests | 22.04% <30.87%> (+0.23%) |
:arrow_up: |
| unittests | 89.25% <91.25%> (+0.20%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| lib/evmone/delegation.cpp | 100.00% <100.00%> (ø) |
|
| lib/evmone/delegation.hpp | 100.00% <100.00%> (ø) |
|
| test/state/host.cpp | 100.00% <100.00%> (ø) |
|
| test/state/precompiles_stubs.cpp | 99.76% <100.00%> (+<0.01%) |
:arrow_up: |
| test/state/transaction.cpp | 95.45% <100.00%> (+1.16%) |
:arrow_up: |
| test/state/transaction.hpp | 100.00% <ø> (ø) |
|
| test/statetest/statetest_runner.cpp | 96.87% <ø> (-0.27%) |
:arrow_down: |
| test/unittests/evm_eof_calls_test.cpp | 100.00% <100.00%> (ø) |
|
| test/unittests/state_transition.cpp | 98.63% <100.00%> (+0.14%) |
:arrow_up: |
| test/unittests/state_transition_eip7702_test.cpp | 100.00% <100.00%> (ø) |
|
| ... and 4 more |
️✅ There are no secrets present in this pull request anymore.
If these secrets were true positive and are still valid, we highly recommend you to revoke them. While these secrets were previously flagged, we no longer have a reference to the specific commits where they were detected. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
GitGuardian warning is clearly a false positive, but also it will go away after devnet3 with this change https://github.com/ethereum/EIPs/pull/8845
~~Remember to drop "WARNING: test case with set_code transaction (type 4) skipped".~~ Added a commit for it.
There are some artificial enviroments where this can crash:
- having invalid delegation designator in state,
- having a precompile with code.
Do you think we should add sanity checks for these when loading tests?
I think it makes sense to add in a separate PR