evmone icon indicating copy to clipboard operation
evmone copied to clipboard

test: Add a state test reaching CALL max depth

Open chfast opened this issue 1 year ago • 3 comments

chfast avatar Sep 13 '24 10:09 chfast

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.90%. Comparing base (1004496) to head (69b3c35).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1007   +/-   ##
=======================================
  Coverage   93.89%   93.90%           
=======================================
  Files         147      147           
  Lines       15507    15519   +12     
=======================================
+ Hits        14561    14573   +12     
  Misses        946      946           
Flag Coverage Δ
eof_execution_spec_tests 17.48% <0.00%> (-0.02%) :arrow_down:
ethereum_tests 27.70% <0.00%> (-0.03%) :arrow_down:
ethereum_tests_silkpre 19.41% <0.00%> (-0.02%) :arrow_down:
execution_spec_tests 18.98% <0.00%> (-0.02%) :arrow_down:
unittests 89.01% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/unittests/state_transition.cpp 97.58% <100.00%> (ø)
test/unittests/state_transition_call_test.cpp 100.00% <100.00%> (ø)

codecov[bot] avatar Sep 13 '24 10:09 codecov[bot]

There's such test in EEST already https://github.com/ethereum/execution-spec-tests/blob/main/tests/prague/eip7692_eof_v1/eip7069_extcall/test_calls.py#L874 (judging by name only, I didn't read the diff)

pdobacz avatar Sep 13 '24 10:09 pdobacz

Yes, I just need one example locally.

It actually crashes because of the stack overflow. This is because we don't run EEST with Clang nor MSVC debug builds.

chfast avatar Sep 13 '24 11:09 chfast