evmc
evmc copied to clipboard
Fix java bindings
-
vm_execute
input data was not handled properly. An additionalinputData
parameter has been added toEvmcVm
'sexecute
function to avoid pointer arithmetics in java -
ReleaseByteArrayElements
was called on a pointer that is not derived fromGetByteArrayElements
causing segfaults -
get_block_hash_fn
typo
Also, it was quite challenging to encode evmc_message
into ByteBuffer and then decode the result. I'd suggest capturing that logic into java classes so the callers won't have to work with memory buffers directly.
Thanks! It seems to fail on CI, can you please check?
Also, it was quite challenging to encode evmc_message into ByteBuffer and then decode the result. I'd suggest capturing that logic into java classes so the callers won't have to work with memory buffers directly.
Absolutely, we did some work on it but didn't had the time to finish. See #542 and #555.
Codecov Report
Merging #651 (ce0c74a) into master (58913e0) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #651 +/- ##
=======================================
Coverage 92.84% 92.84%
=======================================
Files 23 23
Lines 3552 3552
Branches 376 376
=======================================
Hits 3298 3298
Misses 144 144
Partials 110 110
@vvviiimmm Are you using EVMC in Java?