evmc icon indicating copy to clipboard operation
evmc copied to clipboard

Published 20 hours ago • verified publisher icon ethereum

java: introduce proper types and minimise reliance on ByteBuffer/byte[]

Open axic opened this issue 5 years ago • 4 comments

Part of #548.

axic avatar Oct 09 '20 23:10 axic

I really like this idea. Would remove all guessing. Feels like you have some coding issues.

Do you intend for implementors to create Address, Bytes32 Uint256 objects? If so, they'll need public constructors.

atoulme avatar Oct 10 '20 04:10 atoulme

@atoulme thanks! This is still work in progress, hence the draft mode, but I think this would be the safest way to handle things. Only issue is Message which is a mess due to the pointer thingie.

axic avatar Oct 12 '20 20:10 axic

Need to add Result class, and also pass Result/Message in HostContext.call.

axic avatar Mar 23 '21 13:03 axic

This currently contains the desired API from the Java perspective, yet to actually implement all of this. I'm leaning towards now that the C part would need to just receive an instance of Result/Message and manually read/write the fields and compose the C struct, as opposed to trying to construct the C struct from within Java.

axic avatar Mar 23 '21 14:03 axic