evmc icon indicating copy to clipboard operation
evmc copied to clipboard

evmc_execute should take evmc_tx_context as an parameter

Open axic opened this issue 7 years ago • 3 comments

I think all those execution details should be available to the client prior to execution. Do you think any client can be savings by assuming the code will not need those and only lazily populate evmc_tx_context on the first call to to get_tx_context?

axic avatar Aug 31 '18 09:08 axic

This comes down to https://github.com/ethereum/evmjit/issues/110.

chfast avatar Aug 31 '18 10:08 chfast

Potentially this may want to be benchmarked and as such would be postponed to ABIv7.

axic avatar Sep 05 '18 15:09 axic

I believe it is good change. It saves us trouble caching this on VM side. Also, this can be handled very efficiently on the Host side - it requires to create the tx_context once per block, and then update the 2 fields than depend on transaction. If you process transactions in parallel, you need multiple copies per execution thread.

chfast avatar Aug 05 '19 15:08 chfast