ethereum-org-website icon indicating copy to clipboard operation
ethereum-org-website copied to clipboard

Fixed #7817, Handle /txs response correctly for 'Number of transactions today'

Open minhoryang opened this issue 3 years ago • 2 comments

Description

"Number of transactions today" was calculated from the result of /txs (src/lambda/txs.ts) After ecf1791bf5ffae6c3edf756617ab07b7f212ea22 commit (included in v5.0.0), .result was handled in /txs already. So there are no need to handle .result in src/pages-conditional/what-is-ethereum.tsx.

FYI, src/components/StatsBoxGrid.tsx was also using /txs and already patched this in 13 Jul (https://github.com/ethereum/ethereum-org-website/commit/214600eb509ffa228af16fb24f3b939b9c91d995).

Related Issue

#7817

minhoryang avatar Sep 17 '22 10:09 minhoryang

:white_check_mark: ethereum-org-website-dev deploy preview ready

gatsby-cloud[bot] avatar Sep 17 '22 11:09 gatsby-cloud[bot]

Fixed. 스크린샷 2022-09-21 오후 5 13 12 https://ethereumorgwebsitedev01-minhoryangethereumorgwebsitefi.gtsb.io/en/what-is-ethereum/

minhoryang avatar Sep 21 '22 08:09 minhoryang

@all-contributors can you add @minhoryang for code

corwintines avatar Oct 24 '22 21:10 corwintines

@corwintines

I've put up a pull request to add @minhoryang! :tada:

allcontributors[bot] avatar Oct 24 '22 21:10 allcontributors[bot]