ethereum-org-website icon indicating copy to clipboard operation
ethereum-org-website copied to clipboard

Configure new /find-wallet page for translations

Open samajammin opened this issue 2 years ago • 2 comments

Is your feature request related to a problem? Please describe.

As a result of #6274, the page is no longer configured for translations. As part the "wallet upgrades" epic (#7250), we should do this as one of the last steps (i.e. we should make page updates/improvements BEFORE configuring translations).

Describe the solution you'd like

Configure the file(s) for translation.

samajammin avatar Aug 10 '22 00:08 samajammin

@corwintines calling attention to this file to make sure we don't miss it - we'll want to translate these strings: https://github.com/ethereum/ethereum-org-website/blob/dev/src/data/wallets/wallet-filters.ts

samajammin avatar Aug 10 '22 00:08 samajammin

Thanks for making this @samajammin! I think we should be able to do this soon. There are a few changes we should look at for copy from user testing feedback, and want to do a bit of refactoring on some smelly code to clean it up first.

corwintines avatar Aug 10 '22 03:08 corwintines

This issue is stale because it has been open 45 days with no activity.

github-actions[bot] avatar Sep 24 '22 08:09 github-actions[bot]

This has been completed

corwintines avatar Apr 20 '23 04:04 corwintines