ethereum-org-website
ethereum-org-website copied to clipboard
The big bar on top that callout the merge only appear on some pages
Describe the bug
The big bar on top that callout the merge only appear on some pages
Expected behavior
- Should be on all pages?
- or if in just a few, should be consistent
Screenshots

Additional context
pages with top Homepage + MD pages (not sure if all) + some pages in the developers section (here it's not consistent)
This seems to me a good opportunity to address our banner & callout usage across the site & to feed this into the design system. e.g. when should we use this banner component? Should the UI be different for some callout that is page specific ("this content is out of date") vs. applicable to the whole site ("the merge is coming, please update your nodes").
This seems to me a good opportunity to address our banner & callout usage across the site & to feed this into the design system. e.g. when should we use this banner component? Should the UI be different for some callout that is page specific ("this content is out of date") vs. applicable to the whole site ("the merge is coming, please update your nodes").
Agree! Probably a discussion for the design system but I don't think our current callouts are very attention-grabbing if this is important information. Perhaps a good solution would be to have types of callout (i.e. normal, warning, alert). Heres a blog post with multiple types of callouts.
This seems to me a good opportunity to address our banner & callout usage across the site & to feed this into the design system. e.g. when should we use this banner component? Should the UI be different for some callout that is page specific ("this content is out of date") vs. applicable to the whole site ("the merge is coming, please update your nodes").
Agree! Probably a discussion for the design system but I don't think our current callouts are very attention-grabbing if this is important information. Perhaps a good solution would be to have types of callout (i.e. normal, warning, alert). Heres a blog post with multiple types of callouts.
Yes total agree. We probably will split the types of call outs.
- for this issue I was referring to top bar, probably something related to the header component and will have a effect site wide
- For in content call outs we will o other issue because will have implications within the content. probably a isolated component that can be used in the content that can have an attribute for: warning or alert or stand_out
both will be designed within the design system EPIC before coding.
For this issue my idea was if we want to have a quick fix to those screenshots or wait for the fina design system solution.
This issue is stale because it has been open 45 days with no activity.
Given the merge is done, I think this is pretty stale 😅
Going to close this out, and we can address banners in another issue.