ethereum-org-website
ethereum-org-website copied to clipboard
ethereum
Better support for RTL languages
Is your feature request related to a problem? Please describe.
Until now we haven't had significant amounts of RTL (right-to-left-script) content on ethereum.org. With #5080 we translate our Use Ethereum bucket for Arabic and we'll soon have this bucket translated for Farsi (Persian).
Describe the solution you'd like
For a better UX for those reading a RTL language we should make refactors to better support RTL.
Additional context
Want to contribute?
We love contributions from the Ethereum community! Please comment on an issue if you're interested in helping out with a PR.
@minimalsm Sir, is there any way in which I could be of assistance with this?
Thanks for volunteering @SNikhill!
I suspect the best next step is to outline specific changes we could make & align on approaches to implement those changes. @SNikhill feel free to make suggestions!
Hey @SNikhill, thanks for offering to help 😀
This is a pretty significant refactor. I think the highest value approach would be to follow the order of our content-buckets. A very impactful first step would be having proper RTL support for our homepage (bucket one) As far as implementation goes we already have some RTL support but unsure if the approach we have taken is optimal, feel free to suggest alternative approaches if you come up with any—we're definitely open to ideas!
Okay, sure, sir. I shall see what a content bucket is and start with that.
Yes, I remember seeing that isLangRightToLeft() function. I shall let you know as I explore further and have any questions. :)
Things I noticed: (NB: I shall be updating this list)
Language: Arabic (I don't understand it but, do know that it is RTL)
-
[x] If I am on the home page and select a code example, the same tends to be rendered in an incorrect way
-
[ ] Graphs (or plots) on the home page -- Should graphs be reversed in RTL?
-
[x] Position of the icons. In English, these icons are at the end but, in Arabic, they are at the start. [Links in the Footer]
-
[x] Dropdown Carets (Same as the previous point but, more specific)
-
[ ] Search Placeholder text and icon -- A detailed article on Interface Localisation
@minimalsm
Sir, above are some things from the Home Page. Not all of them are a priority.
For Graph, I shall like to suggest that on hover, the position of origin like 0,0 is shown. The same helps in identifying the direction the trend is progressing in.
@SNikhill ahh nice catch on the graph. Never even thought of that... could definitely be confusing 🤔
Any reason we wouldn't have this on by default (instead of just on hover)? Worth noting the ~40% of people on mobile wouldn't be able to use it if it was just available on hover. Also, we're making the assumption that people will hover over it with their mouse whilst viewing it.
Curious if anyone else has any input here.
Sure, we can have it on by default too. If the chart supports it and we can position it the right.
What about the other things? Is the stuff okay to proceed with?
Yes, @SNikhill, all of these seem in the scope of this issue to me. Do you have particular concerns?
This issue is stale because it has been open 45 days with no activity.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@minimalsm
Do you have any tips to optimise the build process? The local build seems to be taking quite long to proceed (and yes, I have increased the heap size to 8192).
This issue is stale because it has been open 45 days with no activity.
(NB: I shall be updating this list)
Essential Page
--- What is Ether(ETH)? --- Wallet Page
-
[ ] Icons/Question Mark positions
Those arrows should probably be towards the end of the line. Just like in Footer Links
This issue is stale because it has been open 45 days with no activity.