ethereum-org-website icon indicating copy to clipboard operation
ethereum-org-website copied to clipboard

Typo Update accordion.tsx

Open 0xwitty opened this issue 1 year ago • 3 comments

Description

There is a minor typo in the className of the ChevronNext icon inside the AccordionTrigger component.

  • In this line:
    <ChevronNext className="size-[1em] shrink-0 text-2xl transition-transform duration-200" />
    
    The size-[1em] class is incorrect because size-[...] is not a valid Tailwind CSS class. It should likely be w-[1em] h-[1em] to set the width and height to 1em.

Correction:

<ChevronNext className="w-[1em] h-[1em] shrink-0 text-2xl transition-transform duration-200" />

This change correctly applies 1em size to both the width and height of the icon.

Fixed.

0xwitty avatar Nov 09 '24 16:11 0xwitty

Deploy Preview for ethereumorg ready!

Name Link
Latest commit 3c8b2791f09aa2d92b881c014a7bec0c7387f825
Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/672f8a57b42d3300084d60fe
Deploy Preview https://deploy-preview-14338--ethereumorg.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
7 paths audited
Performance: 45 (🔴 down 11 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Nov 09 '24 16:11 netlify[bot]

This issue is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Dec 10 '24 08:12 github-actions[bot]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic High Entropy Secret 602d37beb17e0b7858094a5fa4f6e28a9d9a78da src/data/community-events.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

If this detection is a false positive, please contact Oleh Vasylenko (@aldekein) to fix it in the GitGuardian dashboard.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Dec 30 '24 12:12 gitguardian[bot]

Thanks @0xwitty!

image

Unless I'm missing something this appears to be parsing correctly... If I'm mistaken, then we have more to clean up than just that one since we use that pattern in almost 60 places. If that's the case we should open a new issue to track it, but going to close this out in the meantime. Cheers!

wackerow avatar Jul 22 '25 02:07 wackerow