ethereum-org-website
ethereum-org-website copied to clipboard
Grammatical and typo corrections
Added typo corrections to documentation for the following files
ethereum-org-website/blob/dev/docs/applying-storybook.md
The word "on" should be "one." The corrected sentence is: There may be some exceptions, but generally each component should have only one story file.
Corrected.
ethereum-org-website/blob/dev/docs/deploy-process.md
The typical workflow will be as follows: It should be: The typical workflow is as follows:
This is because the description refers to the current process, so "is" would be the correct tense instead of "will be."
Corrected.
ethereum-org-website/blob/dev/docs/event-tracking.md
"Each event comprises of 4 hierarchical values:" The correct phrase should be: "Each event comprises 4 hierarchical values:" The word "comprise" already means "to include," so "of" is unnecessary.
Corrected.
ethereum-org-website/blob/dev/docs/review-process.md
Thereβs a small typo in the "Adding products" section: "... ensure we not sending our users to any dubious or unsafe products." It should be: "... ensure we are not sending our users to any dubious or unsafe products." The word "are" is missing.
Corrected.
Goal
Correct grammatical errors and improve readability of the documentation.
Deploy Preview for ethereumorg ready!
| Name | Link |
|---|---|
| Latest commit | c2d66e14790b5fa5e2f9906e3575190aabc6a381 |
| Latest deploy log | https://app.netlify.com/sites/ethereumorg/deploys/672dcfbc0f765f0008cbb179 |
| Deploy Preview | https://deploy-preview-14332--ethereumorg.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
7 paths audited Performance: 48 (π΄ down 8 from production) Accessibility: 92 (no change from production) Best Practices: 89 (π΄ down 9 from production) SEO: 99 (no change from production) PWA: - View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
This issue is stale because it has been open 30 days with no activity.
β οΈ GitGuardian has uncovered 1 secret following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.
π Detected hardcoded secret in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | - | Generic High Entropy Secret | 602d37beb17e0b7858094a5fa4f6e28a9d9a78da | src/data/community-events.json | View secret |
π Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
If this detection is a false positive, please contact Oleh Vasylenko (@aldekein) to fix it in the GitGuardian dashboard.
π¦ GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@all-contributors please add @mdqst for bug patch
