ethereum-org-website icon indicating copy to clipboard operation
ethereum-org-website copied to clipboard

refactor: extract protected newToCrypto array

Open wackerow opened this issue 1 year ago • 1 comments

Description

  • Extract newToCrypto array into new data file
  • Strictly type names based on wallets data array
  • Type-restrict ability to add this property directly to wallet entry
  • Update CODEOWNERS for approval before changes to data/wallets/new-to-crypto.ts
  • Deprecate wallets-check.yml workflow check

Preview link

https://deploy-preview-14185--ethereumorg.netlify.app/en/wallets/find-wallet/

wackerow avatar Oct 17 '24 21:10 wackerow

Deploy Preview for ethereumorg ready!

Name Link
Latest commit 4e1b569f112a4804a5e489c3406a694d10d77b8f
Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/673b8af9cf69390008a975bd
Deploy Preview https://deploy-preview-14185--ethereumorg.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
7 paths audited
Performance: 50 (🔴 down 4 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 17 '24 21:10 netlify[bot]