ethereum-org-website
ethereum-org-website copied to clipboard
ethereum
Product table refactor
Description
- Refactor out the FindWallets table to a reusable ProductTable that can be used in other use cases (networks coming up, dapps in the future)
Deploy Preview for ethereumorg ready!
| Name | Link |
|---|---|
| Latest commit | ba803defe10514f9de98fc8019970e59143c59d9 |
| Latest deploy log | https://app.netlify.com/sites/ethereumorg/deploys/671874210a22ce0008bd7c4d |
| Deploy Preview | https://deploy-preview-13807--ethereumorg.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
7 paths audited Performance: 46 (🔴 down 7 from production) Accessibility: 92 (🔴 down 1 from production) Best Practices: 89 (🔴 down 9 from production) SEO: 99 (🟢 up 7 from production) PWA: - View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@corwintines these seem to work as multi select, but use radio component leading user to think there is only at a time possible, should switch to checkbox
the subtext should be grey - body medium rather than white by default, turns white on selected
there is supposed to be sticky header with wallet counter and reset button that is missing in preview
when selected persona, the description should turn white, there is also small animation in the prod i think that would be nice to keep
when there is subset of wallets bcs of active filter, it should indicate the amount from total that is visible (see prod)
this is a new thing so can be deprioritized, but when selecting a filter from sidebar the change is instantaneous and if the filter isnt very restricting it doesnt feel like anything has been updated in the list - to indicate the change - we could introduce some smooth quick refresh animation for the listings such as a quick fade out and fade in
testing mobile i had issues clicking on persona in the filter modal, several times and it didnt select. (more looked like just mouse over triggered instead of selection)
testing mobile i had issues clicking on persona in the filter modal, several times and it didnt select. (more looked like just mouse over triggered instead of selection)
maybe issue with clickable area?
- sidebar breaks when scrolling
- when i scroll down and scroll up again and then try scrolling back down it stops working
- missing "x" close button on top (see production, there is sticky x)
above screen shows few issues on mobile in terms of how the design should be structured
bellow screen shows current production - how it should look
I am not sure if it's a bug, but if we aim for feature parity to production the button on tablet size it's not 100% width
just on mobile
The head of the table has a different label. On the PR is way simpler. Was it on purpose?
What is this bar on the top of the mobile filters? We don´t have it on production
What is this bar on the top of the mobile filters? We don´t have it on production
This was part of the drawer component, removed it for now but just saying where it came from
The head of the table has a different label. On the PR is way simpler. Was it on purpose?
I could update this if needed, but I generalized it in the abstraction of this component
Approved from dev side. cc: @nloureiro and/or @konopkja for approval from design side 🙏, then can pull this in (ideally before this weeks release if no critical blockers)
lgtm! last two things i found:
- reset button should be centered with see wallets button (vertically)
- this modal window has oval corners on top, should be straihgt instead