ethereum-org-website icon indicating copy to clipboard operation
ethereum-org-website copied to clipboard

add stablecoins quiz [Fixes #13649]

Open Shiva-Sai-ssb opened this issue 1 year ago • 1 comments

Description

As specified in the issue, I have added the quiz for stablecoins in this PR.

Related Issue

Closes #13649

Shiva-Sai-ssb avatar Aug 22 '24 13:08 Shiva-Sai-ssb

Deploy Preview for ethereumorg ready!

Name Link
Latest commit a66c73dfc4bdb2be599701d23a4954caf77fe8c6
Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/670635ce7a3943000830b042
Deploy Preview https://deploy-preview-13704--ethereumorg.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
7 paths audited
Performance: 43 (🔴 down 10 from production)
Accessibility: 94 (🟢 up 1 from production)
Best Practices: 83 (🔴 down 15 from production)
SEO: 93 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 22 '24 13:08 netlify[bot]

Hey @konopkja,

I need some help with the quiz I'm trying to add. I successfully added the Stablecoins quiz to the quizzes page, and it's working perfectly there. However, when I added the quiz to the Stablecoins page using the StandaloneQuizWidget, it isn't displaying correctly. The quiz questions and options are showing up as in the attached image.

Screenshot (170)

Could you please suggest what's causing this issue and how I can fix it? Thanks in advance!

Shiva-Sai-ssb avatar Sep 04 '24 14:09 Shiva-Sai-ssb

Hey @konopkja,

I need some help with the quiz I'm trying to add. I successfully added the Stablecoins quiz to the quizzes page, and it's working perfectly there. However, when I added the quiz to the Stablecoins page using the StandaloneQuizWidget, it isn't displaying correctly. The quiz questions and options are showing up as in the attached image.

Screenshot (170)

Could you please suggest what's causing this issue and how I can fix it? Thanks in advance!

@pettinarip

konopkja avatar Sep 04 '24 14:09 konopkja

Could you please suggest what's causing this issue and how I can fix it? Thanks in advance!

Hey @Shiva-Sai-ssb good job and thanks for helping on this 🚀

So it looks like the only thing missing here is the i18n support for this page. You will need to manually add the stablecoing page to this condition https://github.com/ethereum/ethereum-org-website/blob/dev/src/lib/utils/translations.ts#L209 in order to load the correct translations for it.

Clarification: the quizzes page already loads this namespace, that is why it works fine there.

pettinarip avatar Sep 04 '24 15:09 pettinarip

Could you please suggest what's causing this issue and how I can fix it? Thanks in advance!

Hey @Shiva-Sai-ssb good job and thanks for helping on this 🚀

So it looks like the only thing missing here is the i18n support for this page. You will need to manually add the stablecoing page to this condition https://github.com/ethereum/ethereum-org-website/blob/dev/src/lib/utils/translations.ts#L209 in order to load the correct translations for it.

Clarification: the quizzes page already loads this namespace, that is why it works fine there.

Thanks a lot for the quick response! I'll go ahead and add the Stablecoins page to the translations condition as suggested. That should hopefully resolve the issue.

Appreciate your help!

Shiva-Sai-ssb avatar Sep 04 '24 16:09 Shiva-Sai-ssb

Hi @konopkja, @pettinarip, sorry for tagging.

I just wanted to let you know that the quiz is now working as expected on both the quizzes page and the stablecoins page. Could you please review this PR?

Shiva-Sai-ssb avatar Sep 10 '24 07:09 Shiva-Sai-ssb

perfect, looks great!! thank you so much for implementing this. People can now learn more about stablecoins in a fun way :)

konopkja avatar Sep 10 '24 11:09 konopkja

@wackerow @pettinarip d do we have to do here anything to include event tracking?

konopkja avatar Sep 10 '24 11:09 konopkja

@wackerow @pabloped do we have to do here anything to include event tracking?

Hey, I think you might have tagged the wrong person here.

Shiva-Sai-ssb avatar Sep 10 '24 13:09 Shiva-Sai-ssb

Please review this. @wackerow

Shiva-Sai-ssb avatar Sep 24 '24 11:09 Shiva-Sai-ssb

Hi @wackerow, thanks for reviewing. I see you have committed all the suggestions you mentioned. Is it done, or is there anything else I should do?

Shiva-Sai-ssb avatar Oct 09 '24 05:10 Shiva-Sai-ssb

@all-contributors please add @Shiva-Sai-ssb for content

wackerow avatar Oct 09 '24 07:10 wackerow

@wackerow

I've put up a pull request to add @Shiva-Sai-ssb! :tada:

allcontributors[bot] avatar Oct 09 '24 07:10 allcontributors[bot]