ethereum-org-website icon indicating copy to clipboard operation
ethereum-org-website copied to clipboard

revert: remove Coin Wallet

Open mahnunchik opened this issue 1 year ago • 3 comments

Add Coin Wallet back.

Description

It seems Coin Wallet was removed by mistake. Coin Wallet supports EIP-1559.

I've updated features list as well.

Related Issue

  • https://github.com/ethereum/ethereum-org-website/issues/6772
  • https://github.com/ethereum/ethereum-org-website/pull/12308
  • https://github.com/ethereum/ethereum-org-website/pull/12308/commits/62a642b44ca4bdab4ce13efd7cd918b6e5036ad5

mahnunchik avatar May 10 '24 17:05 mahnunchik

Deploy Preview for ethereumorg ready!

Name Link
Latest commit 84393e8c4d65b22dc87cb3c6628ce4304bae8a48
Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/667139f186b7240008252154
Deploy Preview https://deploy-preview-12948--ethereumorg.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
7 paths audited
Performance: 42 (🟢 up 4 from production)
Accessibility: 92 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 10 '24 17:05 netlify[bot]

Thanks for bringing this up @mahnunchik

Since this wallet was out of date, I think we should make sure the information we have is updated. Do you mind filling this out so we can have an up to date listing for Coin Wallet and review it in its current state.

corwintines avatar May 13 '24 04:05 corwintines

@corwintines done https://github.com/ethereum/ethereum-org-website/issues/12970

mahnunchik avatar May 15 '24 18:05 mahnunchik

@corwintines ping

mahnunchik avatar May 28 '24 13:05 mahnunchik

Thanks @mahnunchik! @corwintines Have assigned you for review to the issue and PR

wackerow avatar Jun 06 '24 20:06 wackerow

Actually, looks like there are some conflicts which I'm unable to clear myself. @mahnunchik Mind fixing those up and then we can merge in?

wackerow avatar Jun 17 '24 21:06 wackerow

@wackerow I've rebased on top of current dev branch.

mahnunchik avatar Jun 18 '24 07:06 mahnunchik

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

gitpoap-bot[bot] avatar Jun 18 '24 23:06 gitpoap-bot[bot]

@all-contributors please add @mahnunchik for tool

wackerow avatar Jun 18 '24 23:06 wackerow

@wackerow

I've put up a pull request to add @mahnunchik! :tada:

allcontributors[bot] avatar Jun 18 '24 23:06 allcontributors[bot]