ethereum-org-website icon indicating copy to clipboard operation
ethereum-org-website copied to clipboard

fix: ButtonLink onClick handler

Open nhsz opened this issue 9 months ago • 1 comments

This PR updates the ButtonLink component to handle custom onClick events and override its behavior when needed. Fixes the issue of /wallets/find-wallet/ Visit website CTA not being tracking the event when clicked.

Testing

  • Go to /wallets/find-wallet/ now the Visit website button should be triggering the custom handleWalletWebsiteClick event handler
  • Go to any other page like /community/ to check that the ButtonLink component is still working as expected for other cases
Screen Shot 2024-05-08 at 17 06 47

Preview

https://deploy-preview-12935--ethereumorg.netlify.app/wallets/find-wallet

nhsz avatar May 08 '24 20:05 nhsz

Deploy Preview for ethereumorg ready!

Name Link
Latest commit 82e32800b7e19a140b6349e8f5ef87594beaea65
Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/663e80445638220008be92dc
Deploy Preview https://deploy-preview-12935--ethereumorg.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
7 paths audited
Performance: 52 (🔴 down 4 from production)
Accessibility: 92 (no change from production)
Best Practices: 94 (🔴 down 4 from production)
SEO: 95 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 08 '24 20:05 netlify[bot]