ethereum-org-website
ethereum-org-website copied to clipboard
ethereum
multiple personas clickable [Fixes #12645]
Description
Allows multi select for personas
For display of wallet tables, when multiple personas are selected, filters are applied after applying AND on all persona preset filters from useWalletPersonas.tsx
The current filtering logic for displaying results is open for review. I welcome any suggestions or requirements for adjustments to ensure the functionality meets our needs
Preview link
https://deploy-preview-12753--ethereumorg.netlify.app/en/wallets/find-wallet
Related issue
- Fixes #12645
Deploy Preview for ethereumorg ready!
| Name | Link |
|---|---|
| Latest commit | 3df57c53baf171f7418a9e34b21c077f72f363bd |
| Latest deploy log | https://app.netlify.com/sites/ethereumorg/deploys/663fddf293d26100085d72ad |
| Deploy Preview | https://deploy-preview-12753--ethereumorg.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
7 paths audited Performance: 49 (🔴 down 7 from production) Accessibility: 92 (no change from production) Best Practices: 89 (🔴 down 9 from production) SEO: 95 (no change from production) PWA: - View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks @bhargavkakadiya! First glance looks like a great start, but per original issue (#12645):
Switch logic to "AND" and allow users to select multiple personas.
Looks like the logic here results in an "OR" result where it'll filter wallets that match a persona OR filters that match another persona (widening results with more checks)...
@konopkja Am I correct that we want to narrow the results as more checkboxes are added?
Thanks for the contribution!!! yeas our goal is to narrow down
@wackerow @konopkja Thanks for the review and inputs, I will update the logic
@wackerow I have updated to show narrowed results, can you please review it again?
@bhargavkakadiya in this example, end result should be 4 wallets or less, as it was narrowed to 4 when clicking the mobile filter
So close! This is definitely nuanced logic... @bhargavkakadiya Replicated Nico's steps above and it kept narrowing down appropriately, but when I uncheck the "Finance" persona, the filters do not broaden again, and the results stay filtered to only three:
https://github.com/ethereum/ethereum-org-website/assets/54227730/3b70f5b4-6ac8-47e6-8c85-f93f63d0e8f2
In this current version, the broadening is working upon deselecting persona.
Also, based on the example below, when mobile is checked, it checks Android and iOS, which is fine. But, when persona Finance is unchecked, it unchecks Android and iOS as well, but mobile is still checked. I will have to work on this yet, haven't figured easy fix for that yet
Screencast from 05-14-2024 09:46:36 AM.webm