ethereum-org-website icon indicating copy to clipboard operation
ethereum-org-website copied to clipboard

Improper redirection in 404 page when clicking on "return home" link or ethereum logo

Open Codex-Bugmenot opened this issue 1 year ago • 11 comments

Describe the bug

In the 404 page with text "We couldn't find that page" the link return home is expected to redirect to "https://ethereum.org/en/" or "https://ethereum.org/" but it redirects you to "https://ethereum.org/en/enindex/" which again is a non-existent page

To reproduce

  1. Visit a 404 page , i used "https://ethereum.org/en/1"
  2. Click on return home link or ethereum logo(top-left)
  3. Now observe you've been redirected to "https://ethereum.org/en/enindex" instead of home page

Expected behavior

When clicking on return home link or ethereum logo from a 404 page it should redirect to home page instead of "https://ethereum.org/en/enindex" page

Screenshots

404Page 404enIndex

Desktop (please complete the following information)

  • Browser: Brave

Smartphone (please complete the following information)

-Browser: Brave

Additional context

No response

Would you like to work on this issue?

  • [ ] Yes
  • [X] No

Codex-Bugmenot avatar Mar 15 '24 20:03 Codex-Bugmenot

I'd like to work on this issue, can I be assigned?

tomasgrusz avatar Mar 16 '24 11:03 tomasgrusz

Thanks @Codex-Bugmenot for reporting! Indeed getting the same result on my end—in Brave and Safari.

@tomasgrusz Thanks for volunteering to help! Just assigned you, let us know if you hit issues

@all-contributors please add @Codex-Bugmenot for bug report

wackerow avatar Mar 18 '24 23:03 wackerow

@wackerow

I've put up a pull request to add @Codex-Bugmenot! :tada:

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

allcontributors[bot] avatar Mar 18 '24 23:03 allcontributors[bot]

I think i just found another small issue in the 404 page should i report it here or open another issue?

Codex-Bugmenot avatar Mar 19 '24 19:03 Codex-Bugmenot

I think there's another small issue in the 404 page should i report it here or open a nother issue?

what's the issue? I already have a PR ready for review, so if it's too different, let's create a new one. Otherwise I think it could be addressed here.

tomasgrusz avatar Mar 19 '24 19:03 tomasgrusz

It's definitely different (not related to redirection), ill open a new issue and do the @tomasgrusz there 👍

Codex-Bugmenot avatar Mar 19 '24 19:03 Codex-Bugmenot

@tomasgrusz , here is the link to the other small issue i mentioned about https://github.com/ethereum/ethereum-org-website/issues/12505

Codex-Bugmenot avatar Mar 19 '24 20:03 Codex-Bugmenot

Yes, a new issue is perfect, thanks @Codex-Bugmenot.

wackerow avatar Mar 19 '24 21:03 wackerow

This issue is stale because it has been open 45 days with no activity.

github-actions[bot] avatar May 04 '24 08:05 github-actions[bot]

Hey @tomasgrusz! Going to un-assign for now, but please feel free to comment and jump back in if you'd like

wackerow avatar May 25 '24 15:05 wackerow

This issue is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Jun 25 '24 08:06 github-actions[bot]

Removing stale tag

corwintines avatar Jul 04 '24 05:07 corwintines

This issue is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Aug 03 '24 08:08 github-actions[bot]

Elevating as this breaks all 404 experiences, and has been problematic for a while.

wackerow avatar Aug 12 '24 19:08 wackerow

This issue is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Sep 12 '24 08:09 github-actions[bot]

Tested this out today and seems to be resolved, going to close this out.

corwintines avatar Mar 13 '25 18:03 corwintines