ethereum-org-website icon indicating copy to clipboard operation
ethereum-org-website copied to clipboard

Chart text without overlapping

Open Satglow opened this issue 1 year ago • 12 comments

Is your feature request related to a problem? Please describe.

Annual Energy Consumption chart – the translated text is overlapping each other. Shall the long expressions put in a hyphenated way (as a translation), following the column width somehow? Or a language-based automatic hyphenation can be applied for these strings?

https://ethereum.org/hu/what-is-ethereum

Annual energy cons chart - text

Describe the solution you'd like

Readable text below the chart.

Describe alternatives you've considered

None

Additional context

No response

Would you like to work on this issue?

  • [ ] Yes
  • [X] No

Satglow avatar Feb 02 '24 15:02 Satglow

@nloureiro @pettinarip should we have a storybook up to provide isolated visual testing of these charts?

Not seeing a clean solution without the chart being it's own block beneath the content at a higher breakpoint. 🤔

TylerAPfledderer avatar Feb 06 '24 16:02 TylerAPfledderer

@nloureiro @pettinarip should we have a storybook up to provide isolated visual testing of these charts?

Not seeing a clean solution without the chart being it's own block beneath the content at a higher breakpoint. 🤔

this is a kinda unique chart, not a component that will be reused, I think, right?

if yes, it might not need to be in the storybook. dunno, what do you think?

nloureiro avatar Feb 06 '24 16:02 nloureiro

Thanks to @Satglow for reporting this bug!

@nloureiro not sure what should be the best approach here, automatic hyphenation might be an easy workaround, but not the ideal as it makes it hard to read. Another idea: we could reduce the number of columns shown for certain locales.

======

@TylerAPfledderer SB related, yeah, not sure if a story for this component is worth it (this could be covered in the page stories if we have them at some point xD), but wouldn't hurt if you still want to do it. Anyway, do you know if Chromatic has snapshots per locale? I think it will always only take one snapshot per component unless we somehow specify that we want to use a different locale (???). Or are you thinking of some other way to test this?

pettinarip avatar Feb 07 '24 15:02 pettinarip

Thanks to @Satglow for reporting this bug!

@nloureiro not sure what should be the best approach here, automatic hyphenation might be an easy workaround, but not the ideal as it makes it hard to read. Another idea: we could reduce the number of columns shown for certain locales.

======

@TylerAPfledderer SB related, yeah, not sure if a story for this component is worth it (this could be covered in the page stories if we have them at some point xD), but wouldn't hurt if you still want to do it. Anyway, do you know if Chromatic has snapshots per locale? I think it will always only take one snapshot per component unless we somehow specify that we want to use a different locale (???). Or are you thinking of some other way to test this?

I didn't have anything in particular. But for a snapshot per locale, can consider Chromatic modes: https://www.chromatic.com/docs/modes/

I can at the very least look at applying this globally.

TylerAPfledderer avatar Feb 07 '24 22:02 TylerAPfledderer

This issue is stale because it has been open 45 days with no activity.

github-actions[bot] avatar Mar 24 '24 08:03 github-actions[bot]

Hi I would love to work on this

WebSculptor avatar Apr 28 '24 15:04 WebSculptor

Hey, @WebSculptor !

What do you have in mind for solving this?

TylerAPfledderer avatar Apr 29 '24 00:04 TylerAPfledderer

This issue is stale because it has been open 30 days with no activity.

github-actions[bot] avatar May 30 '24 08:05 github-actions[bot]

@pettinarip @nhsz is this solved by the new graph framework?

nloureiro avatar May 30 '24 10:05 nloureiro

Adding this to dev sync to clear up

corwintines avatar Jun 25 '24 19:06 corwintines

This issue is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Jul 26 '24 08:07 github-actions[bot]

@corwintines did we get an answer here?

minimalsm avatar Aug 20 '24 11:08 minimalsm