ethereum-org-website icon indicating copy to clipboard operation
ethereum-org-website copied to clipboard

Change operator `||` to `??` where reading environmental valuable [Fixes #12057]

Open HiroyukiNaito opened this issue 1 year ago • 3 comments

Change operator || to ?? where reading environmental valuable [Fixes #12057]

Description

When reading environmental valuables, it is safer to use '??' operator. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing

Related Issue

#12057

HiroyukiNaito avatar Jan 30 '24 09:01 HiroyukiNaito

Deploy Preview for ethereumorg ready!

Name Link
Latest commit 113e81b8b547c331f39da52eeb8c1bd2dc4f0647
Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65bb29925729690008bdccfa
Deploy Preview https://deploy-preview-12058--ethereumorg.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jan 30 '24 09:01 netlify[bot]

@wackerow Thank you for the deep insight. I would change the code according to your description.

HiroyukiNaito avatar Feb 01 '24 03:02 HiroyukiNaito

@wackerow I changed codes according to your advice.

HiroyukiNaito avatar Feb 01 '24 05:02 HiroyukiNaito