ethereum-org-website icon indicating copy to clipboard operation
ethereum-org-website copied to clipboard

SideNav

Open pettinarip opened this issue 2 years ago • 14 comments

Our current SideNav used in the developer docs section, needs to be refactored to use the new DS styles

image

pettinarip avatar Jul 21 '23 09:07 pettinarip

I can work on this issue

Nagapadmini7 avatar Jul 30 '23 17:07 Nagapadmini7

@pettinarip would like to work on this issue

ameeetgaikwad avatar Aug 26 '23 00:08 ameeetgaikwad

Hi @ameeetgaikwad! assigning it to you, thanks!

pettinarip avatar Aug 31 '23 06:08 pettinarip

@ameeetgaikwad pls consider using the Accordion for this implementation

pettinarip avatar Aug 31 '23 06:08 pettinarip

@ameeetgaikwad please do not ask for review in issues. That's the purpose of the Pull Request. Also, can't do a proper review based off of a screenshot. 😸

Hmmm hey @pettinarip, we might be getting too far ahead in making this an available issue. Getting a PR going now for this might clash with getting the accordion theme online... particularly because there is #10936 open. 🤔

I would assume that this sidenav component is dependent on that other PR's completion, no?

TylerAPfledderer avatar Sep 01 '23 01:09 TylerAPfledderer

@TylerAPfledderer so sorry, I'll delete that comment.

ameeetgaikwad avatar Sep 01 '23 02:09 ameeetgaikwad

Correct. Good point @TylerAPfledderer. This PR will be on hold until we merge the Accordion implementation.

pettinarip avatar Sep 04 '23 10:09 pettinarip

This issue is stale because it has been open 45 days with no activity.

github-actions[bot] avatar Oct 20 '23 08:10 github-actions[bot]

Circling back, this hasn't been forgotten... #10936 has had a couple updates, trying to get that in then will come back to this one.

wackerow avatar Mar 28 '24 22:03 wackerow

This issue is stale because it has been open 30 days with no activity.

github-actions[bot] avatar May 09 '24 08:05 github-actions[bot]

This issue is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Jun 15 '24 08:06 github-actions[bot]

Removing stale tag since this has a draft PR in progress

corwintines avatar Jul 03 '24 04:07 corwintines

This issue is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Aug 02 '24 08:08 github-actions[bot]

Reassigning this to @pettinarip as he has an open (draft) PR here.

minimalsm avatar Aug 20 '24 12:08 minimalsm

This issue is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Sep 20 '24 08:09 github-actions[bot]