ethash icon indicating copy to clipboard operation
ethash copied to clipboard

missing cmake install()

Open subtly opened this issue 9 years ago • 2 comments

In cpp-eth, running make && make install && /path/to/install/eth fails with an error that libethash.so can't be found. Should work with or without opencl and installed for shared-library based deployments.

See also: https://github.com/ethereum/cpp-ethereum/pull/1756

Logs: https://build.ethdev.com/builders/Linux%20C%2B%2B%20develop%20server/builds/434/steps/start/logs/eth.err

subtly avatar Apr 27 '15 15:04 subtly

To reproduce: cmake .. -DBUNDLE=minimal && make && make install && /usr/local/bin/eth -b

cc @LefterisJP

subtly avatar Apr 27 '15 18:04 subtly

Great. I don't think that anyone has tried ethash with shared libraries yet or with make install so that' something that needed fixing. Thanks.

But shouldn't the PR also be in the ethash repo? At the moment there is a confusion as for which is the repo to commit changes to but my understanding is that in the long run the master repo for ethash changes should be this and cpp ethereum should just be pulling the changes.

LefterisJP avatar Apr 27 '15 20:04 LefterisJP