eth-typing icon indicating copy to clipboard operation
eth-typing copied to clipboard
verified publisher icon ethereum

Warn about deprecated EthPM types

Open reedsa opened this issue 1 year ago • 2 comments

What was wrong?

Related to Issue # Closes #

How was it fixed?

Todo:

  • [ ] Clean up commit history

  • [ ] Add or update documentation related to these changes

  • [ ] Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

reedsa avatar Apr 17 '24 16:04 reedsa

Not finding a convenient way to make this warn when those types are imported specifically. Should the deprecation belong in the web3 v7 migration guide? @kclowes @fselmo @pacrob

reedsa avatar Apr 17 '24 20:04 reedsa

Should the deprecation belong in the web3 v7 migration guide?

Yeah, can be mentioned along with the removal of the EthPM module there.

I don't have any better ideas for getting the deprecation to show up though. Is your _DeprecatedType not working as planned?

pacrob avatar Apr 18 '24 19:04 pacrob