eth-account icon indicating copy to clipboard operation
eth-account copied to clipboard

wip: introduce py-hdwallet

Open wolovim opened this issue 4 years ago • 2 comments

What does it do?

Introduces py-hdwallet for child key derivation.

(WIP: seeking feedback on items below)

Background

  • My understanding of the plan is for py-hdwallet to eventually provide all BIP32-related functionality within eth-account. This introduction of the library only goes as far as replicating existing functionality recently introduced by @fubuloubu.
  • Mnemonics are currently outside of the scope of py-hdwallet, so @fubuloubu's recent mnemonic work would go untouched.

TODO:

  • [ ] put all testing in its right place, e.g., remove or alter relevant tests in eth-account; some tests are better suited for py-hdwallet.
  • [ ] agree on hardening representation (e.g., ', h, H, etc.)
    • py-hdwallet only supports h
    • the eth-account implementation had support for ' and H

Cute Animal Picture

put a cute animal picture link inside the parentheses

wolovim avatar Apr 07 '20 22:04 wolovim

The ' is the standard representation IIRC. It should be supported prior to either of the other ones. Understanding it's not exactly the most legible in code, but a simple replace would solve that.

fubuloubu avatar Apr 07 '20 22:04 fubuloubu

Also, a nice thing that should be introduced at some point is an alternative account type that can continuously derive new accounts using hdwallet, and encrypts/decrypts the master key instead of the account key. This would come in handy primarily for testing use (deriving multiple test accounts from a seed), but would set the stage for hardware wallet integration (which uses hd paths to obtain the account from master public key).

fubuloubu avatar Apr 07 '20 23:04 fubuloubu