eipw icon indicating copy to clipboard operation
eipw copied to clipboard

Special case `markdown-rel-links` to help when linking to eips.ethereum.org

Open SamWilsn opened this issue 3 years ago • 7 comments

For example:

Error: error[markdown-rel-links]: non-relative link or image
  --> EIPS/eip-5190.md
   |
17 | This EIP also extends account-bound token from [EIP-4973](https://eips.ethereum.org/EIPS/eip-4973), but the difference is that it can be transferred to other account for mobility between managing device.
   |
   = help: use `./eip-4973.md` instead

SamWilsn avatar Jul 14 '22 13:07 SamWilsn

Also do https://creativecommons.org/publicdomain/zero/1.0/.

SamWilsn avatar Jul 15 '22 14:07 SamWilsn

I will work on this issue. Ty.

JEAlfonsoP avatar Feb 17 '23 23:02 JEAlfonsoP

Proposal for PR:

Modify relative_links.rs to add an AnnotationType::Help to the footer when regex matches: link && !link

JEAlfonsoP avatar Feb 22 '23 00:02 JEAlfonsoP

Changed the example so that it works with other types of links, not just ones of the form [abc](def).

SamWilsn avatar Apr 21 '23 17:04 SamWilsn

@SamWilsn can you assign me this repo?

Hari-Bombon avatar May 20 '24 04:05 Hari-Bombon

I've collected the tests JEAlfonsoP and I came up with over here: https://github.com/ethereum/eipw/tree/issue-5

Might be a good starting place for anyone working on this issue, though I can't promise they're totally up to date.

SamWilsn avatar May 20 '24 23:05 SamWilsn

I've collected the tests JEAlfonsoP and I came up with over here: https://github.com/ethereum/eipw/tree/issue-5

Might be a good starting place for anyone working on this issue, though I can't promise they're totally up to date.

Anything I can help just let me know. Cheers

JEAlfonsoP avatar May 21 '24 11:05 JEAlfonsoP