eipw icon indicating copy to clipboard operation
eipw copied to clipboard

Markdown lint to ensure inline solidity with a `SPDX-License-Identifier` has a license of CC0.

Open SamWilsn opened this issue 3 years ago • 10 comments

This ticket is to generate a diagnostic message for code blocks within the EIP itself. For example, this should generate an error:

## Abstract

...

## Specification

All compliant tokens MUST implement:

```solidity
// SPDX-License-Identifier: MIT

interface FooToken {
    // ...
}
```

## Rationale

...

SamWilsn avatar Jul 15 '22 03:07 SamWilsn

@SamWilsn could you let me know if this has been fixed or not ? and if not could you please provide and error example. Thank You !

JEAlfonsoP avatar Feb 26 '23 04:02 JEAlfonsoP

There's a PR open to add this already: https://github.com/ethereum/EIPs/pull/5379

Pandapip1 avatar Feb 26 '23 19:02 Pandapip1

Thanks @Pandapip1 I will talk to @SamWilsn in order to close all issues fixed already.

JEAlfonsoP avatar Feb 26 '23 20:02 JEAlfonsoP

@Pandapip1 does that license checker check code fence blocks inside of EIPs themselves? For some reason I thought it only checked *.sol files in the assets directory.

This ticket is to generate a diagnostic message for code blocks within the EIP itself. For example:

## Abstract

...

## Specification

All compliant tokens MUST implement:

```solidity
// SPDX-License-Identifier: MIT

interface FooToken {
    // ...
}
```

## Rationale

...

SamWilsn avatar Feb 27 '23 20:02 SamWilsn

This is accurate. You're right; eipw should lint EIPs to check for SPDX identifiers that are not CC0-1.0.

Pandapip1 avatar Feb 27 '23 20:02 Pandapip1

Superseded by license checker CI.

Pandapip1 avatar Apr 17 '23 17:04 Pandapip1

Hi, could you please let me know if this issue has been solved or not ? Ty.

JEAlfonsoP avatar Apr 21 '23 00:04 JEAlfonsoP

Superseded by license checker CI.

For inline as well?

SamWilsn avatar Apr 21 '23 15:04 SamWilsn

For inline as well?

Yup, it detects inline SPDX headers.

Pandapip1 avatar Apr 25 '23 13:04 Pandapip1

Sam, If this is it, so the issue should be closed. !? Ty.

JEAlfonsoP avatar Apr 25 '23 23:04 JEAlfonsoP