consensus-specs icon indicating copy to clipboard operation
consensus-specs copied to clipboard

Demonstrate adding `EIP7594_MAX_BLOBS_PER_BLOCK` and `EIP7594_TARGET_BLOBS_PER_BLOCK`

Open hwwhww opened this issue 1 year ago • 5 comments

Suggested by @barnabasbusa that we could add configurable parameters for devnet-4.

I'll put them with EIP7594_ prefix for now and switch them once we move to Fulu.

hwwhww avatar Oct 02 '24 17:10 hwwhww

For historical reasons, we probably wanna redefine deneb as well:

# deneb renames? 
DENEB_BLOB_SIDECAR_SUBNET_COUNT = 6
DENEB_MAX_BLOBS_PER_BLOCK = 6
DENEB_TARGET_BLOBS_PER_BLOCK = 3

EIP7594_BLOB_SIDECAR_SUBNET_COUNT = 8
EIP7594_MAX_BLOBS_PER_BLOCK = 8
EIP7594_TARGET_BLOBS_PER_BLOCK = 4

barnabasbusa avatar Oct 02 '24 17:10 barnabasbusa

``

Gulrizwan23 avatar Oct 03 '24 19:10 Gulrizwan23

to be consistent with what we've done previously with MAX_REQUEST_BLOCKS and MAX_REQUEST_BLOCKS_DENEB I think we should keep existing names as is and add

BLOB_SIDECAR_SUBNET_COUNT_PECTRA: 8
# MAX_REQUEST_BLOCKS_DENEB * MAX_BLOBS_PER_BLOCK_PECTRA
MAX_REQUEST_BLOB_SIDECARS_PECTRA: 1024
MAX_BLOBS_PER_BLOCK_PECTRA: 8
TARGET_BLOBS_PER_BLOCK_PECTRA: 4

In theory, since there is no previous TARGET_BLOBS_PER_BLOCK, to do the exact same thing we did before we should add it without PECTRA but maybe in this case we could add it straight.

tbenr avatar Oct 21 '24 14:10 tbenr

BLOB_SIDECAR_SUBNET_COUNT_PECTRA: 8
# MAX_REQUEST_BLOCKS_DENEB * MAX_BLOBS_PER_BLOCK_PECTRA
MAX_REQUEST_BLOB_SIDECARS_PECTRA: 1024
MAX_BLOBS_PER_BLOCK_PECTRA: 8
TARGET_BLOBS_PER_BLOCK_PECTRA: 4

PECTRA would be ELECTRA here i assume...

rolfyone avatar Oct 22 '24 07:10 rolfyone

PECTRA would be ELECTRA here i assume...

oh gosh 🤦 ... obviously...

BLOB_SIDECAR_SUBNET_COUNT_ELECTRA: 8
# MAX_REQUEST_BLOCKS_DENEB * MAX_BLOBS_PER_BLOCK_ELECTRA
MAX_REQUEST_BLOB_SIDECARS_ELECTRA: 1024
MAX_BLOBS_PER_BLOCK_ELECTRA: 8
TARGET_BLOBS_PER_BLOCK_ELECTRA: 4

tbenr avatar Oct 22 '24 07:10 tbenr

These variables are now part of the Fulu spec

dapplion avatar Mar 25 '25 04:03 dapplion