consensus-specs icon indicating copy to clipboard operation
consensus-specs copied to clipboard

Remove phase0~capella state transition tests from testgen

Open hwwhww opened this issue 1 year ago • 1 comments

Address #3634

Remove phase0-capella state transition tests:

  • epoch_processing
  • finality
  • ~~fork_choice~~
  • forks
  • genesis
  • light_client
  • operations
  • random
  • rewards
  • sanity
  • sync
  • transition

Note:

  1. The tests written in phase0 folder will still be included in the Deneb test vectors.
  2. We will still run tests on CI with minimal presets.

hwwhww avatar Apr 24 '24 11:04 hwwhww

the idea is generally that these test vectors don't change, esp once we have gotten to a particular fork (e.g. phase0-capella test data doesn't change with respect to deneb)

and so we want to drop this test generation from the produced test corpus -- so that it becomes smaller

I think this is fine -- one thing to not is that assuming the test outputs don't change, then you can go to a previous release of the spec tests and get the data still; so this just changes the way we handle the data, and doesn't change what test data is available

it sounds like your intention is no change to how it currently works for deneb, and in either case we will still run all tests in CI (w/ minimal preset)

one thing I would also suggest is that we just ensure we do run the "full" test suite once per spec release, just so we can ensure the tests all pass -- and then under this PR we would just skip generating the test artifacts

ralexstokes avatar Apr 25 '24 14:04 ralexstokes

I am closing this issue because it seems stale. Please, do not hesitate to reopen it if this is a mistake

leolara avatar Jun 04 '25 08:06 leolara