consensus-specs icon indicating copy to clipboard operation
consensus-specs copied to clipboard

Redundant SSZ generic tests

Open hwwhww opened this issue 2 years ago • 1 comments

Thank @winsvega for reporting it.

Issue

For example, the tests uint_128_max_0 - uint_128_max_4 are redundant because variation doesn't make difference in non-random tests.

It also applies to other SSZ types:

Its not just with uint. Other folders also have similar same tests. Looks like a bug in test generator script. Also the containers. Ssz requires a structure. There it goes input {a, b, c, d, e} But it actually is { [a,b], c, d, e} or similar. And the container also has redundant tests

How to fix it?

Go thought the get_random_ssz_object helper and check if variation was wrongly used in non-random tests.

hwwhww avatar May 02 '23 09:05 hwwhww

did #3468 resolve this? if so, we can close the issue

ralexstokes avatar Apr 03 '24 19:04 ralexstokes

I am closing this issue because it seems stale. Please, do not hesitate to reopen it if this is a mistake

leolara avatar Jun 10 '25 09:06 leolara