consensus-specs icon indicating copy to clipboard operation
consensus-specs copied to clipboard
verified publisher icon ethereum

Add specs for vanity art

Open etan-status opened this issue 2 years ago • 3 comments

Update specifications to match client implementation behaviour regarding optional vanity art being displayed when certain conditions are met.

etan-status avatar Apr 12 '23 12:04 etan-status

Why should we have all the clients follow this art spec?

This seems to me that it's an implementation thing rather than a spec thing. The protocol will work fine if not all the clients follow the art spec.

Even though it's marked as optional, it's still a sign that we convince all the clients to follow the spec if we put it in the spec.

ppopth avatar Apr 25 '23 07:04 ppopth

This seems related to https://github.com/ethereum/consensus-specs/pull/2875

ppopth avatar Apr 25 '23 08:04 ppopth

It's all optional and "may". This PR documents existing client behaviour. The panda is in most of them, the owl in some, blobfish hasn't hit yet.

  • Nimbus: https://github.com/status-im/nimbus-eth2/tree/unstable/beacon_chain/consensus_object_pools/vanity_logs
  • Lodestar: https://github.com/ChainSafe/lodestar/tree/unstable/packages/beacon-node/src/chain/blocks/utils
  • Lighthouse: https://github.com/sigp/lighthouse/blob/21dec6f603edd53ad8d2372941c77ab8098d3b5a/beacon_node/beacon_chain/src/block_verification.rs#L90-L112
  • Prysm: https://github.com/prysmaticlabs/prysm/blob/a7c9c76b18fb71cb680c81b69414e11c97db7ca2/beacon-chain/blockchain/merge_ascii_art.go
  • Teku: https://github.com/ajsutton/teku/blob/e77cd2a36ee1c341dd367620c0025c2bce0be4de/ethereum/statetransition/src/main/resources/tech/pegasys/teku/statetransition/forkchoice/panda.txt

etan-status avatar Apr 25 '23 08:04 etan-status

I am closing this issue because it seems stale. Please, do not hesitate to reopen it if this is a mistake

leolara avatar Jun 04 '25 08:06 leolara