consensus-specs icon indicating copy to clipboard operation
consensus-specs copied to clipboard

EIP4844: couple beacon block and blob sidecar for p2p

Open terencechain opened this issue 3 years ago • 3 comments

Part of #3043

Here we couple beacon block and blob sidecar under a single gossip topic- beacon_block_and_blob_sidecar. We introduce a new network container SignedBeaconBlockAndBlobsSidecar which consists of SignedBeaconBlock and SignedBlobsSidecar. We also combined the previous gossips beacon_block and blobs_sidecar validations under beacon_block_and_blob_sidecar. I think we can get rid of blob.beacon_block_root and blob.beacon_block_slot, I'm curious to hear more thoughts

cc @protolambda @Inphi

Rationale for coupling: https://notes.ethereum.org/RLOGb1hYQ0aWt3hcVgzhgQ?#Gossip

terencechain avatar Oct 17 '22 23:10 terencechain

:+1: on coupling

dapplion avatar Oct 18 '22 13:10 dapplion

I think we need some clarification on how we want to propagate beacon blocks that don't have sidecars

Do we want to support this? It feels like more complexity and takes us back to de-coupling block and blob

terencechain avatar Oct 18 '22 18:10 terencechain

I think empty lists in the existing structs here should be sufficient

realbigsean avatar Oct 18 '22 20:10 realbigsean

I think we need some clarification on how we want to propagate beacon blocks that don't have sidecars

Do we want to support this? It feels like more complexity and takes us back to de-coupling block and blob

Agreed. it isn't clear to me from my reading of the spec that we'll use coupled blocks even when there isn't a sidecar. Let's clarify this in the spec. We can deprecate/remove the old topic used for (decoupled) beacon blocks.

Inphi avatar Oct 19 '22 03:10 Inphi

should we add the description of how to prepare SignedBeaconBlockAndBlobsSidecar in validator.md?

hwwhww avatar Oct 20 '22 15:10 hwwhww

should we add the description of how to prepare SignedBeaconBlockAndBlobsSidecar in validator.md?

Good point, I'll update that today

terencechain avatar Oct 20 '22 16:10 terencechain