consensus-specs icon indicating copy to clipboard operation
consensus-specs copied to clipboard

Fix/hysteresis on active validator

Open leckylao opened this issue 3 years ago • 1 comments

Skipping hysteresis on pending validator

leckylao avatar Oct 17 '22 04:10 leckylao

While this is an edgecase affecting a desired functionality for your application, I think it unlikely that this is altered (especially soon) given (1) the functionality of 1 ETH deposits was designed for "top-ups" rather than iterative deposits and (2) that the desired functionality can be achieved trivially through the use of a smart contract on the execution layer.

Given (2) and the design goal of simplicity in CL, my personal preference is to leave as is and to put a warning in the validator guide.

Note: This cannot just be changed in Phase 0 (as specified). It might be changed in a subsequent spec and hard fork. If this is to be entertained for a future hard fork, I suggest putting this in it's own spec folder (e.g. specs/hystereris-fix) as a diff to bellatrix (the latest stable fork)

djrtwo avatar Oct 18 '22 14:10 djrtwo

While this is an edgecase affecting a desired functionality for your application, I think it unlikely that this is altered (especially soon) given (1) the functionality of 1 ETH deposits was designed for "top-ups" rather than iterative deposits and (2) that the desired functionality can be achieved trivially through the use of a smart contract on the execution layer.

It would be easier for a new protocol for the change and it is a big impact for us. But agreed and we have the same expectation and working on the infrastructure upgrade to fix it.

Given (2) and the design goal of simplicity in CL, my personal preference is to leave as is and to put a warning in the validator guide.

Agreed. Definitely good to put warning to prevent this from happening again. Could also put the stuck validators as example that there's case would need 33 ETH to activate a validator.

Note: This cannot just be changed in Phase 0 (as specified). It might be changed in a subsequent spec and hard fork. If this is to be entertained for a future hard fork, I suggest putting this in it's own spec folder (e.g. specs/hystereris-fix) as a diff to bellatrix (the latest stable fork)

Right, made sense. I have moved that into a separate folder as suggested. Thank you for the feedback.

leckylao avatar Oct 21 '22 02:10 leckylao

Please note it was added in phrase 0 with all tests pass before moving into sub folder. https://github.com/ethereum/consensus-specs/pull/3045/files

leckylao avatar Nov 19 '22 01:11 leckylao