consensus-specs icon indicating copy to clipboard operation
consensus-specs copied to clipboard

Use only Eth1 ChainID

Open nisdas opened this issue 5 years ago • 2 comments

Currently in the official mainnet config: https://github.com/ethereum/eth2.0-specs/blob/dev/configs/mainnet/phase0.yaml#L55

both the Chain ID and Network ID are specified, however for our purposes we only require the Eth1 Chain ID . This was brought about from Go-Ethereum removing the net_version rpc method in their latest release, which made it unable for prysm to run with geth's latest release.

https://github.com/ethereum/go-ethereum/issues/22034 https://github.com/prysmaticlabs/prysm/issues/8170 https://github.com/sigp/lighthouse/issues/2115 https://github.com/prysmaticlabs/prysm/issues/8124

Given that eth_chainID is the canonical way to determine which actual chain the node is on, we should default to only using that as described in the EIP: https://eips.ethereum.org/EIPS/eip-695

The network_id is a network parameter rather than anything chain specific, so it isn't required for our usecase.

nisdas avatar Dec 23 '20 01:12 nisdas

Seems like clients are generally moving away from the net_ dependency in the move to clean things up in the engine api.

@nisdas does this require anything from the consensus-specs repo or can I close this issue?

djrtwo avatar Jun 20 '22 12:06 djrtwo

The removing of net_ dependency would address this issue. For our consensus-specs repo, can we remove references to the network id ? Ex:

https://github.com/ethereum/consensus-specs/blob/dev/configs/mainnet.yaml#L94

nisdas avatar Jun 20 '22 15:06 nisdas