ethereum
Deploy PURITY_CHECKER and MSG_HASHER with via compile in testing
Issue
PURITY_CHECKER and MSG_HASHER are currently deployed via previously sign txs in the testing framework. This is super opaque and makes it tough to test any changes to purity checker. It is also not how we plan on deploying in the EIP
Proposed implementation
- ensure msg_hasher and purity_checker source are in the repo
- compile and deploy dynamically in testing rather than sending a previously sign tx
BLOCKER: #69 and #73. Both of these issues port msg_hasher and purity_checker to vyper LLL so we don't have to introduce serpent as a dependency.
Thanks for this @djrtwo -- I had the same concern while working on purity_checker but figured it was this way for a reason.
I ended up doing this for purity_checker and the issue I ran into was that what I want to do is import the Vyper LLL but given the structure of the tests and the source code I had to modify the PYTHONPATH to get all of the modules lined up.
Can anyone think of a preferred way to import code from the contracts module into the tests without doing this? I suppose if its unavoidable then we can add a Makefile to abstract it away...
@djrtwo I'd like to own this. @ralexstokes I'm just getting familiar with Vyper (familiar with solidity), would be nice if I could ping you to get some of your learnings from doing purity_checker.
That works for me. You can start building off of the purity checker PR/branch. Should be merged tmw
On Tuesday, June 12, 2018, kiel barry [email protected] wrote:
@djrtwo https://github.com/djrtwo I'd like to own this. @ralexstokes https://github.com/ralexstokes I'm just getting familiar with Vyper (familiar with solidity), would be nice if I could ping you to get some of your learnings from doing purity_checker.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ethereum/casper/issues/159#issuecomment-396759269, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXf-40bwxn_t93Ep-FEU7SuUgV7dnp1ks5t8EXJgaJpZM4UUIxL .