beacon-APIs icon indicating copy to clipboard operation
beacon-APIs copied to clipboard

Update attestation related APIs to be compatible with EIP-7549

Open tbenr opened this issue 1 year ago • 6 comments

attestations for Electra require an additional committee_bits field.

I think these APIs are effected. /eth/v1/beacon/pool/attestations /eth/v1/beacon/blocks/{block_id}/attestations /eth/v1/validator/aggregate_attestation

tbenr avatar Apr 26 '24 18:04 tbenr

Also /eth/v1/validator/aggregate_and_proofs

rkapka avatar Apr 27 '24 12:04 rkapka

Something minor but I believe attester slashing is affected because the max length of attesting_indices in IndexedAttestation is changed. So get and post /eth/v1/beacon/pool/attester_slashings

ensi321 avatar Apr 29 '24 06:04 ensi321

Would note that there's a conceptual difference in get/put type APIs. Both worth discussing, but adding polymorphism present challenges to different parts of the stack. The initial list of three all returns an Attestation-like structure for example, which implies a particular type system setup to handle that.

tersec avatar Apr 29 '24 19:04 tersec

https://ethereum.github.io/beacon-APIs/#/Events/eventstream has an attestation event type, potentially affected

tersec avatar May 02 '24 08:05 tersec

I suspect we need to move /eth/v1/validator/aggregate_attestation to v2, 'cose committee index parameter is required to BN if we want to produce aggregates only for the committee the validator is in. cc @mkalinin

tbenr avatar May 03 '24 16:05 tbenr

I suspect we need to move /eth/v1/validator/aggregate_attestation to v2, 'cose committee index parameter is required to BN if we want to produce aggregates only for the committee the validator is in. cc @mkalinin

Yes, the committee_index has to be passed explicitly onto this call, because the EIP tends to preserve the network part of the aggregation strategy

mkalinin avatar May 06 '24 13:05 mkalinin

This should be complete, we decided to not update the eventstream api

nflaig avatar Feb 11 '25 14:02 nflaig