aleth icon indicating copy to clipboard operation
aleth copied to clipboard

aleth-precompiles library

Open gumb0 opened this issue 6 years ago • 3 comments

Fixes https://github.com/ethereum/aleth/issues/5788

This replaces the precompiles infrastructure with the new EVMC module library.

Information about which revision activates each precompile for now is still in ChainParams class.

Option to build as a shared library is not added yet.

gumb0 avatar Nov 28 '19 18:11 gumb0

Codecov Report

Merging #5855 into master will increase coverage by 0.02%. The diff coverage is 86.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5855      +/-   ##
==========================================
+ Coverage   63.94%   63.96%   +0.02%     
==========================================
  Files         365      364       -1     
  Lines       31098    31103       +5     
  Branches     3441     3441              
==========================================
+ Hits        19885    19895      +10     
+ Misses       9980     9974       -6     
- Partials     1233     1234       +1

codecov-io avatar Dec 23 '19 14:12 codecov-io

What was the blocker on this? Lack of time / lack of usefulness?

axic avatar May 06 '20 10:05 axic

What was the blocker on this? Lack of time / lack of usefulness?

Rather lack of usefulness.

But this PR is ready from my side except evmc_create_aleth_precompiles naming problem mentioned above.

gumb0 avatar May 06 '20 13:05 gumb0