aleth icon indicating copy to clipboard operation
aleth copied to clipboard

Get Aleth working with retesteth

Open halfalicious opened this issue 6 years ago • 7 comments

@gumb0 Reported that Aleth doesn't work with retesteth and that this needs to be investigated and fixed.

halfalicious avatar Oct 15 '19 04:10 halfalicious

@winsvega your input would be useful here

gumb0 avatar Oct 22 '19 13:10 gumb0

I tried running state tests with retesteth in "alethIPCDebug" mode - that is, when retesteth connects to already running client via IPC socket.

It required changes in some configs https://github.com/ethereum/tests/pull/656 Then many tests pass, but precompile-related ones fail because of the issue in retesteth https://github.com/ethereum/retesteth/issues/60 Also, aleth incorrectly answers debug_accountRangeAt https://github.com/ethereum/aleth/issues/5815 but that is a problem only when running retesteth with high log verbosity.

gumb0 avatar Nov 12 '19 17:11 gumb0

Another fix in configs needed: https://github.com/ethereum/tests/pull/659

And another issue in aleth affecting running tests around precompiles https://github.com/ethereum/aleth/issues/5819

gumb0 avatar Nov 13 '19 17:11 gumb0

Another fix in configs needed: https://github.com/ethereum/tests/pull/660

gumb0 avatar Nov 18 '19 13:11 gumb0

Another fix in configs needed to fix CHAINID test failure https://github.com/ethereum/tests/pull/661

gumb0 avatar Nov 18 '19 14:11 gumb0

With the fixes to configs above the only errors left are caused by https://github.com/ethereum/retesteth/issues/60

I have tried so far only running the state tests and only in IPC-attach mode. There are still many things more we could try:

  • Runnning blockchain tests
  • Generating the tests
  • Running in HTTP mode with dopple
  • Running in the mode where retesteth starts aleth process(es)
  • Running with retesteth in docker

gumb0 avatar Nov 21 '19 13:11 gumb0

This commands should run without errors: -t GeneralStateTests
-t GeneralStateTests --filltests
-t GeneralStateTests --filltests --fillchain

-t BlockchainTests could throw some errors. the blockchain test generation works only for ValidBlocks.

TransitionTests does not work on geth. Might be configuration issue.

winsvega avatar Nov 21 '19 14:11 winsvega