aleth icon indicating copy to clipboard operation
aleth copied to clipboard

Create EIP1380 gas cost tests for aleth-interpreter

Open halfalicious opened this issue 5 years ago • 0 comments

I've created eip1380 (call-to-self) tests which exercise my LegacyVM implementation (see #5752) and validate gas costs but still need to create tests which validate my aleth-interpreter implementation (which was merged in #5753). The tests will need to be created using EVMOne since the EVMC interface doesn't allow one to validate gas costs (EVMC::exec doesn't take a callback).

For reference, one validates the gas cost of LegacyVM ops via the OnOp callback passed in here: https://github.com/ethereum/aleth/blob/a3cdc87abb8fb30a4293ca3bef28004c5b3ce2d3/libevm/LegacyVM.cpp#L207

EVMC::exec doesn't accept this callback parameter: https://github.com/ethereum/aleth/blob/a3cdc87abb8fb30a4293ca3bef28004c5b3ce2d3/libaleth-interpreter/VM.cpp#L237

EVMOne's test infrastructure has support for validating gas costs, I need to investigate how it works.

halfalicious avatar Oct 15 '19 03:10 halfalicious