ERCs icon indicating copy to clipboard operation
ERCs copied to clipboard

Fix assets redirect

Open Divide-By-0 opened this issue 1 year ago • 5 comments

Pull Request

https://github.com/ethereum/ERCs/pull/242

What happened?

I make assets/erc-#/. Then I hyperlink to text in my docs. It errors with HTML Proofer since file doesn't exist.

In this commit, we fix it by changing erc-# to eip-#, even though that folder doesn't exist.

On compilation, I think assets/erc-# should automatically ln/symlink to assets/eip-# so that behavior is always intuitive.

Relevant log output

  • At ./_site/EIPS/eip-7524.html:252: internally linking to ../assets/erc-7524/sec2-v2.pdf, which does not exist

  • At ./_site/EIPS/eip-7524.html:281: internally linking to ../assets/erc-7524/sec1-v2.pdf, which does not exist

I get this issue from HTMLProofer when hyperlinking intuitively for the way it compiles in VSCode.

Divide-By-0 avatar Feb 07 '24 03:02 Divide-By-0

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

github-actions[bot] avatar May 19 '24 00:05 github-actions[bot]

This seems like a small thing that would complete the eip to erc migration, and at the very least should be in the docs.

Divide-By-0 avatar May 19 '24 04:05 Divide-By-0

Agreed! @lightclient how hard is this to do?

SamWilsn avatar May 22 '24 17:05 SamWilsn

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

github-actions[bot] avatar Jul 02 '24 00:07 github-actions[bot]

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

github-actions[bot] avatar Jul 11 '24 00:07 github-actions[bot]

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback.

github-actions[bot] avatar Jan 17 '25 00:01 github-actions[bot]