EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Add EIP: Deactivate EIP-158

Open gballet opened this issue 1 year ago • 4 comments

gballet avatar Jul 02 '24 19:07 gballet

File EIPS/eip-7733.md

Requires 1 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @samwilsn

eth-bot avatar Jul 02 '24 19:07 eth-bot

The commit 3f365e8079ae23dd9c4a5fd7b5bf984b1ec8d3b9 (as a parent of 45e5d19ad2cb42454797fbbdecffa508b781528f) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 03 '24 07:07 github-actions[bot]

BTW, I think you mean EIP-161

https://github.com/ethereum/EIPs/blob/master/EIPS/eip-607.md https://github.com/ethereum/EIPs/blob/master/EIPS/eip-161.md

jochem-brouwer avatar Jul 03 '24 15:07 jochem-brouwer

This EIP is so vague that it is not entirely clear to me what you propose to change.

the change is the deactivation of eip 158/161... How could I possibly make it any clearer in your view?

It seems to have been written to attempt to deal with an unfortunate edgecase that arises from one reading of EIP-7702. You should probably fixing EIP-7702 to handle this edgecase better instead.

~~That is a much more complex fix than simply deactivating eip 158, and it would effectively be the same thing.~~ there was a push to make the nonce 1 when calling a 7702 contract, this is no longer true.

gballet avatar Jul 04 '24 14:07 gballet

Since this hasn't made it into the repository, I'm just going to close this PR instead of merging it as Withdrawn.

SamWilsn avatar Jul 09 '24 14:07 SamWilsn