EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Links from EIPs to ERCs cause `eipw` to fail

Open SamWilsn opened this issue 1 year ago • 5 comments

Pull Request

https://github.com/ethereum/EIPs/pull/8594/files

What happened?

When you link from an EIP to an ERC using the correct syntax, the markdown-link-status lint errors out. This is incorrect.

Relevant log output

2024-06-17T02:18:49.9597214Z ##[error]error[markdown-link-status]: unable to read file `eip-7683.md`: Io: JsValue(Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
    at async open (node:internal/fs/promises:636:25)
    at async readFile (node:internal/fs/promises:1246:14))
  --> EIPS/eip-7713.md
   |
26 | A recent example is found in [ERC-7683](./eip-7683.md), which defines a struct with the following member:
   |
   = help: see https://ethereum.github.io/eipw/markdown-link-status/
2024-06-17T02:18:49.9625536Z ##[error]error[markdown-refs]: unable to read file `eip-7683.md`: Io: JsValue(Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
    at async open (node:internal/fs/promises:636:25)
    at async readFile (node:internal/fs/promises:1246:14))
  --> EIPS/eip-7713.md
   |
26 | A recent example is found in [ERC-7683](./eip-7683.md), which defines a struct with the following member:
   |
   = help: see https://ethereum.github.io/eipw/markdown-refs/
2024-06-17T02:18:49.9634594Z ##[error]validation found errors :(

SamWilsn avatar Jun 25 '24 14:06 SamWilsn

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

github-actions[bot] avatar Aug 22 '24 00:08 github-actions[bot]

Żądanie ściągnięcia

https://github.com/ethereum/EIPs/pull/8594/files

Co się stało?

When you link from an EIP to an ERC using the correct syntax, the markdown-link-status lint errors out. This is incorrect.

Odpowiednie wyjście dziennika

2024-06-17T02:18:49.9597214Z ##[error]error[markdown-link-status]: unable to read file `eip-7683.md`: Io: JsValue(Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
    at async open (node:internal/fs/promises:636:25)
    at async readFile (node:internal/fs/promises:1246:14))
  --> EIPS/eip-7713.md
   |
26 | A recent example is found in [ERC-7683](./eip-7683.md), which defines a struct with the following member:
   |
   = help: see https://ethereum.github.io/eipw/markdown-link-status/
2024-06-17T02:18:49.9625536Z ##[error]error[markdown-refs]: unable to read file `eip-7683.md`: Io: JsValue(Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
    at async open (node:internal/fs/promises:636:25)
    at async readFile (node:internal/fs/promises:1246:14))
  --> EIPS/eip-7713.md
   |
26 | A recent example is found in [ERC-7683](./eip-7683.md), which defines a struct with the following member:
   |
   = help: see https://ethereum.github.io/eipw/markdown-refs/
2024-06-17T02:18:49.9634594Z ##[error]validation found errors :(

Mortiemi avatar Sep 03 '24 19:09 Mortiemi

Hey @SamWilsn can I have this one pls?

rutefig avatar Sep 18 '24 09:09 rutefig

Hey @SamWilsn can I have this one pls?

@rutefig is the offer still valid? I think Sam may have missed this at the time, or it may have gotten lost among the recent avalanche of spambots posting one-line gibberish... maybe just proceed to PR without being formally assigned?

bumblefudge avatar Jan 20 '25 15:01 bumblefudge

Hey @SamWilsn can I have this one pls?

@rutefig is the offer still valid? I think Sam may have missed this at the time, or it may have gotten lost among the recent avalanche of spambots posting one-line gibberish... maybe just proceed to PR without being formally assigned?

yes, the offer is still valid. Make sense, I will proceed with the PR then. Thank you

rutefig avatar Jan 20 '25 15:01 rutefig

Hey @SamWilsn can I have this one pls?

@rutefig is the offer still valid? I think Sam may have missed this at the time, or it may have gotten lost among the recent avalanche of spambots posting one-line gibberish... maybe just proceed to PR without being formally assigned?

hey there, so actually I think this issue should be referred to the ethereum/eipw repo, so maybe that is why @SamWilsn missed this one

rutefig avatar Jan 31 '25 11:01 rutefig

Run DavidAnson/markdownlint-cli2-action@f5cf187ef11bd3a68a127321b794aa252ff23019 markdownlint-cli2-config v0.6.0 (markdownlint v0.27.0) Finding: EIPS/eip-7864.md Linting: 1 file(s) Summary: 2 error(s) Error: EIPS/eip-7864.md:22 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Field: BN254 scalar field"] Error: EIPS/eip-7864.md:32 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "1. Split the 32-byte value int..."] Error: Failed with exit code: 1

@Quantum_ATS contact me i'm developer

endebeny avatar Feb 26 '25 18:02 endebeny

هل لا قمت بمساعدتي يحل المشكله

Hgaras avatar May 04 '25 00:05 Hgaras