EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Update EIP-2935: note possible ADD overflow

Open chfast opened this issue 1 year ago • 3 comments

chfast avatar Apr 23 '24 21:04 chfast

File EIPS/eip-2935.md

Requires 1 more reviewers from @g11tech, @gballet, @jochem-brouwer, @jsign, @tanishqjasoria, @tkstanczak, @vbuterin

eth-bot avatar Apr 23 '24 21:04 eth-bot

ahh thank you for reviewing: have addressed it like this: ~~- https://github.com/ethereum/EIPs/pull/8514~~

  • https://github.com/ethereum/EIPs/pull/8515

since subtraction will also involve underflow check etc, and input is not going to go beyond 8 bytes which is the type size assumed in various specs including the CL spec types

g11tech avatar May 03 '24 12:05 g11tech

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Jun 22 '24 00:06 github-actions[bot]

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

github-actions[bot] avatar Aug 03 '24 00:08 github-actions[bot]