Add EIP: EOF - Prepare for Address Space Extension
Update EOF opcodes so addresses are not trimmed during execution, reverting with an exception if the address is invalid.
✅ All reviewers have approved.
@axic, @g11tech, @gcolvin, @lightclient, @SamWilsn is there anything keeping this from being merged?
@axic, @g11tech, @gcolvin, @lightclient, @SamWilsn is there anything keeping this from being merged?
could you separate out the update from new eip addition please
Will separating out parallel updates be a standard request of all new EIPs? If so, should that be baked into validation checks?
Will separating out parallel updates be a standard request of all new EIPs? If so, should that be baked into validation checks?
yea I guess we should do that. added few nits else should be gtm
Nits addressed. Please merge.
@axic, @g11tech, @gcolvin, @lightclient, @SamWilsn is there anything keeping this from being merged?
approved, not sure why bot isn't working
The commit 12169362dde8181fcbdc62d5cd016805c0884bce (as a parent of dd5418715c12ca04480ee884636e833507c2f500) contains errors. Please inspect the Run Summary for details.
Not a link but a reference by name. Eth-bot shut that one down quick. How else would you propose acknowledge existing tests and reference implementations?
In this case calling out it's specific location seemed warranted because the organization of tests for that case is fairly non-intuitive, and expecting the readers to do a search themselves without signposts moves it in the direction of "trust me bro, tests exist."
We still treat "references by name" as links. It's just easier to detect URLs than vague English :rofl:
Interestingly we do allow links to EEST:
https://github.com/ethereum/EIPs/blob/6a0a792731c16d92d56e0525dd0abff7b498d7b7/config/eipw.toml#L151-L152
Would it be useful to consider allowing links to ethereum/tests?