EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Update EIP-3475: Changing comments

Open dhruvmalik007 opened this issue 2 years ago • 3 comments

description defined in the interface file.

dhruvmalik007 avatar Oct 17 '22 04:10 dhruvmalik007

A critical exception has occurred: Message: pr 5789 is already merged; quitting (cc @alita-moore, @mryalamanchi)

eth-bot avatar Oct 17 '22 04:10 eth-bot

Could you explain the changes you're making to this EIP? It's in the final state, so generally we don't allow updates.

SamWilsn avatar Oct 18 '22 21:10 SamWilsn

Could you explain the changes you're making to this EIP? It's in the final state, so generally we don't allow updates.

hi @SamWilsn , we wanted to rectify the description of the example information that is defined in the interface as many developers were having hard time understanding the notations like [1,10,00] storage of the Transaction tuple, which is shown as the pseudo-code , but other readers who were developing on the standard were getting errors.

so the changes are only in the descriptions and never change either the function interface or standard

dhruvmalik007 avatar Oct 23 '22 12:10 dhruvmalik007

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Jan 07 '23 00:01 github-actions[bot]

There's some sort of weird github bug going on with this PR. @dhruvmalik007 please re-submit.

Pandapip1 avatar Jan 07 '23 00:01 Pandapip1

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Jan 24 '23 00:01 github-actions[bot]

ah sorry didnt checked this PR issue, ok I will close this one and re-create a new PR.

dhruvmalik007 avatar Jan 24 '23 05:01 dhruvmalik007

ah sorry didnt checked this PR issue, ok I will close this one and re-create a new PR.

No need. Not sure why this didn't merge the 1st time.

Pandapip1 avatar Jan 24 '23 14:01 Pandapip1