ethereum
Update EIP-5732: Move to Last Call
- [x] Add ENS Ref Impl
- [x] Move to last call
- [ ] Update last call deadline to 2 weeks ahead before merge
All tests passed; auto-merging...
(pass) eip-5732.md
| classification |
|---|
updateEIP |
- passed!
The payable modifier should also be considered for this interface's commit() function.
There are some use-cases where the initial commit will want to accept a transaction value that we would want to support.
Adding a payable keyword also lowers the number of opcodes being executed (no check for msg.value == 0), which lowers the gas consumption. Many production use-cases will include it in the final contract design for gas efficiency reasons even if it doesn't use msg.value, assuming there is no security concern with accepting it.
@mattstam good point, thanks for the contribution.
@Pandapip1 @SamWilsn this is ready for merge
@Pandapip1 Thanks for reviewing this: https://github.com/ethereum/EIPs/pull/5758 I was curious, why the eipbot didn't approve it despite you already approved it
