EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Add EIP-5700: Bindable Token Standard

Open leeren opened this issue 2 years ago • 3 comments

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

leeren avatar Sep 21 '22 03:09 leeren

All tests passed; auto-merging...

(pass) eip-5700.md

classification
updateEIP
  • passed!

(pass) assets/eip-5700/erc1155/ERC1155.sol

classification
ambiguous
  • file assets/eip-5700/erc1155/ERC1155.sol is associated with EIP 5700; because there are also changes being made to EIPS/eip-5700.md all changes to corresponding assets are also allowed

(pass) assets/eip-5700/erc1155/ERC1155Bindable.sol

classification
ambiguous
  • file assets/eip-5700/erc1155/ERC1155Bindable.sol is associated with EIP 5700; because there are also changes being made to EIPS/eip-5700.md all changes to corresponding assets are also allowed

(pass) assets/eip-5700/erc1155/ERC1155Binder.sol

classification
ambiguous
  • file assets/eip-5700/erc1155/ERC1155Binder.sol is associated with EIP 5700; because there are also changes being made to EIPS/eip-5700.md all changes to corresponding assets are also allowed

(pass) assets/eip-5700/erc721/ERC721.sol

classification
ambiguous
  • file assets/eip-5700/erc721/ERC721.sol is associated with EIP 5700; because there are also changes being made to EIPS/eip-5700.md all changes to corresponding assets are also allowed

(pass) assets/eip-5700/erc721/ERC721Bindable.sol

classification
ambiguous
  • file assets/eip-5700/erc721/ERC721Bindable.sol is associated with EIP 5700; because there are also changes being made to EIPS/eip-5700.md all changes to corresponding assets are also allowed

(pass) assets/eip-5700/erc721/ERC721Binder.sol

classification
ambiguous
  • file assets/eip-5700/erc721/ERC721Binder.sol is associated with EIP 5700; because there are also changes being made to EIPS/eip-5700.md all changes to corresponding assets are also allowed

(pass) assets/eip-5700/interfaces/IERC1155Bindable.sol

classification
ambiguous
  • file assets/eip-5700/interfaces/IERC1155Bindable.sol is associated with EIP 5700; because there are also changes being made to EIPS/eip-5700.md all changes to corresponding assets are also allowed

(pass) assets/eip-5700/interfaces/IERC1155BindableErrors.sol

classification
ambiguous
  • file assets/eip-5700/interfaces/IERC1155BindableErrors.sol is associated with EIP 5700; because there are also changes being made to EIPS/eip-5700.md all changes to corresponding assets are also allowed

(pass) assets/eip-5700/interfaces/IERC1155Binder.sol

classification
ambiguous
  • file assets/eip-5700/interfaces/IERC1155Binder.sol is associated with EIP 5700; because there are also changes being made to EIPS/eip-5700.md all changes to corresponding assets are also allowed

(pass) assets/eip-5700/interfaces/IERC1155BinderErrors.sol

classification
ambiguous
  • file assets/eip-5700/interfaces/IERC1155BinderErrors.sol is associated with EIP 5700; because there are also changes being made to EIPS/eip-5700.md all changes to corresponding assets are also allowed

(pass) assets/eip-5700/interfaces/IERC1155Errors.sol

classification
ambiguous
  • file assets/eip-5700/interfaces/IERC1155Errors.sol is associated with EIP 5700; because there are also changes being made to EIPS/eip-5700.md all changes to corresponding assets are also allowed

(pass) assets/eip-5700/interfaces/IERC721Bindable.sol

classification
ambiguous
  • file assets/eip-5700/interfaces/IERC721Bindable.sol is associated with EIP 5700; because there are also changes being made to EIPS/eip-5700.md all changes to corresponding assets are also allowed

(pass) assets/eip-5700/interfaces/IERC721BindableErrors.sol

classification
ambiguous
  • file assets/eip-5700/interfaces/IERC721BindableErrors.sol is associated with EIP 5700; because there are also changes being made to EIPS/eip-5700.md all changes to corresponding assets are also allowed

(pass) assets/eip-5700/interfaces/IERC721Binder.sol

classification
ambiguous
  • file assets/eip-5700/interfaces/IERC721Binder.sol is associated with EIP 5700; because there are also changes being made to EIPS/eip-5700.md all changes to corresponding assets are also allowed

(pass) assets/eip-5700/interfaces/IERC721BinderErrors.sol

classification
ambiguous
  • file assets/eip-5700/interfaces/IERC721BinderErrors.sol is associated with EIP 5700; because there are also changes being made to EIPS/eip-5700.md all changes to corresponding assets are also allowed

(pass) assets/eip-5700/interfaces/IERC721Errors.sol

classification
ambiguous
  • file assets/eip-5700/interfaces/IERC721Errors.sol is associated with EIP 5700; because there are also changes being made to EIPS/eip-5700.md all changes to corresponding assets are also allowed

eth-bot avatar Sep 21 '22 03:09 eth-bot

@Pandapip1 Seems like the failing tests are unrelated to my EIP changes? What's the right way to diagnose?

leeren avatar Oct 25 '22 22:10 leeren

@Pandapip1 removed watermarks per your request!

leeren avatar Nov 17 '22 03:11 leeren

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Dec 02 '22 00:12 github-actions[bot]

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

github-actions[bot] avatar Jan 13 '23 00:01 github-actions[bot]

Could this please be re-opened?

leeren avatar Jan 16 '23 20:01 leeren

Will be updating this soon with changes after reflecting on limitations. I've also done a deep analysis on all other EIPs touching on ownership attribution and will add a section on how this differs and the types of compromises being made. Just commenting here to make it clear that this EIP is not dead and a lot of effort will soon be put forth again to asking for feedback!

leeren avatar May 04 '23 04:05 leeren