EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Update EIP-1: Fix Backward Compatibility Typos

Open Pandapip1 opened this issue 2 years ago • 4 comments

This has been bugging me for a while. Thoughts?

Pandapip1 avatar Sep 18 '22 17:09 Pandapip1

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-1.md

classification
updateEIP
  • Changes to EIP 1 require at least 5 unique approvals from editors; there's currently 1 approvals; the remaining editors are @lightclient, @axic, @samwilsn, @gcolvin

(fail) eip-template.md

classification
ambiguous
  • 'eip-template.md' must be in eip-###.md format; this error will be overwritten upon relevant editor approval

eth-bot avatar Sep 18 '22 17:09 eth-bot

I think they're both acceptable, and prefer the option that doesn't require changing eipw :rofl:

SamWilsn avatar Sep 30 '22 19:09 SamWilsn

I think they're both acceptable, and prefer the option that doesn't require changing eipw 🤣

Should we add a [sic] then?

Pandapip1 avatar Oct 02 '22 12:10 Pandapip1

both are technically correct

Every spell checker I've used disagrees.

I can change the 5000+ files if need be. I think we can also just keep the old files as having the old form until they are changed. I volunteer to try to fix eipw.

Pandapip1 avatar Oct 04 '22 11:10 Pandapip1

I am ok ether way. I just hope it be consistent across the board....

xinbenlv avatar Nov 11 '22 17:11 xinbenlv

Although this is the more accepted form, both are technically correct. I think that it's best to leave as-is so that we don't need to change 5000+ EIPs and eipw.

There are <1000 EIPs, and it's possible to automate this in a few minutes (see my change with the LICENSE file)

Pandapip1 avatar Nov 12 '22 13:11 Pandapip1

@SamWilsn and I have both expressed that we do not want to pursue this change.

lightclient avatar Nov 13 '22 17:11 lightclient