EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

EIP-4907: Fixed typos

Open 0fatih opened this issue 2 years ago • 15 comments

0fatih avatar Aug 09 '22 14:08 0fatih

A critical exception has occurred: Message: pr 5435 is already merged; quitting (cc @alita-moore, @mryalamanchi)

eth-bot avatar Aug 09 '22 14:08 eth-bot

The commit ebbfbcdbec695ff9e99be99d7aca8768d17b02c7 (as a parent of 5dad76ea9f96c706f42a988543dc493728cbbdc6) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 09 '22 14:08 github-actions[bot]

eipw errors need to be fixed

Pandapip1 avatar Aug 09 '22 18:08 Pandapip1

@Pandapip1 Bot complains about the title:

3 | title: Rental NFT, ERC-721 User And Expires Extension
  |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ too long

I didn't even touch the title. Should I change it?

0fatih avatar Aug 14 '22 09:08 0fatih

Suggest change the title to : Rental NFT, an Extension of EIP-721

0xanders avatar Aug 14 '22 09:08 0xanders

The commit 20754b29e3da60f84194a833eaa547d22ec1a5f0 (as a parent of d161f27ee19fce95da165b78f05132d2ef8a6c8f) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 14 '22 11:08 github-actions[bot]

Are these requirements new?

Error: proposals must be referenced with the form `EIP-N` (not `ERC-N`)
Error: proposals must be referenced with the form `EIP-N` (not `ERC-N`)
Error: proposals must be referenced with the form `EIP-N` (not `ERC-N`)
Error: proposals must be referenced with the form `EIP-N` (not `ERC-N`)
Error: proposals must be referenced with the form `EIP-N` (not `ERC-N`)
Error: proposals must be referenced with the form `EIP-N` (not `ERC-N`)
Error: proposals must be referenced with the form `EIP-N` (not `ERC-N`)
Error: proposals must be referenced with the form `EIP-N` (not `ERC-N`)
Error: validation found errors :(

Guys this is my first PR to EIPs. I wanted to start with the basics (typos). What is going on? What should I do?

0fatih avatar Aug 14 '22 11:08 0fatih

Yes, those are requirements. Just replace all instances of ERC-X with EIP-X.

Pandapip1 avatar Aug 14 '22 11:08 Pandapip1

IERC4907.sol, ERC4907.sol , ERC4907Demo.sol are file names, you can add ` to them , such as [IERC4907.sol]

0xanders avatar Aug 14 '22 12:08 0xanders

The commit 4b78aa7d15d9d3e49239053163b93f02e2891754 (as a parent of 470c5e91708bfc6aeee044fc3d3ca23d3dce5db6) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 14 '22 12:08 github-actions[bot]

The commit f9d972a5ae36866837502b3065b7d3273e398439 (as a parent of 58223185ef5e5c76911bcaf3a1a3ea7e608a89bc) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 14 '22 12:08 github-actions[bot]

The commit 6df7d66276ac42e330aac320a34b57a5dd77772c (as a parent of 484913a0717123a263a0339f8c2f074e975b5b10) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 14 '22 12:08 github-actions[bot]

The commit 7082bc10eba634eb26ad187df489f7485b660825 (as a parent of 1f36d0427726d0ad5936eb65a9f4256e8f226c7f) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 14 '22 12:08 github-actions[bot]

The commit 32e2ebfa46f37ad509b62b90a761a940f9729418 (as a parent of 6eff0f3624823b8c2db9806d17192765c29e8e9a) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 14 '22 12:08 github-actions[bot]

Needs approval by @0xanders, or @LanceSnow

Pandapip1 avatar Aug 15 '22 18:08 Pandapip1